Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document middleware on_request and on_response #2398

Merged
merged 4 commits into from
Feb 13, 2022

Conversation

Bluenix2
Copy link
Contributor

Summary

When looking through the documentation I was unable to find these two methods, without docstrings these methods do not show up in the autogenerated documentation.


There's not much more to say about this change.

Without docstrings these methods do not show up in the autogenerated documentation.
@Bluenix2 Bluenix2 requested a review from a team as a code owner February 11, 2022 20:12
prryplatypus
prryplatypus previously approved these changes Feb 11, 2022
Copy link
Member

@prryplatypus prryplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2398 (240ae58) into main (68b654d) will decrease coverage by 0.059%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #2398       +/-   ##
=============================================
- Coverage   87.167%   87.107%   -0.060%     
=============================================
  Files           60        60               
  Lines         5003      5003               
  Branches       905       905               
=============================================
- Hits          4361      4358        -3     
- Misses         470       472        +2     
- Partials       172       173        +1     
Impacted Files Coverage Δ
sanic/mixins/middleware.py 100.000% <ø> (ø)
sanic/server/protocols/http_protocol.py 84.523% <0.000%> (-3.572%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68b654d...240ae58. Read the comment docs.

prryplatypus
prryplatypus previously approved these changes Feb 12, 2022
@Bluenix2
Copy link
Contributor Author

Bluenix2 commented Feb 12, 2022

I don't understand how any of my changes correlate to the tests failing. 🤔

sanic/mixins/middleware.py Outdated Show resolved Hide resolved
sanic/mixins/middleware.py Outdated Show resolved Hide resolved
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition.

@ahopkins ahopkins merged commit d4fb44e into sanic-org:main Feb 13, 2022
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants